Originally Posted By: NTDOC
Hi Mark,

Just a few comments (I'll leave Glenn to help with the coding) \:D

KiXtart v4.x
Unless you've tested it with KiXtart 4.0, 4.02, 4.22, etc... then I'd enter the version you did test under dependencies.


Done

 Originally Posted By: NTDOC

;License: Creative Commons Attribution 3.0 United States
; http://creativecommons.org/licenses/by/3.0/us/
Though this is not a bad deal I don't think we can accept it as a posted UDF with this license
We've never actually used any type of license (probably should have) but have basically used the principal
that ALL publicly posted code on the site is free to use in any shape form or manner one wishes to.


This is a little more complex. As I'm sure you are aware this license leaves it open to use by anyone only attribution is required. Living in the Land of the Free and the Home of the Lawyers my concern is that some scumbag might take some of the code and patent/register/trademark (WHATEVER, I don't care for lawyers) it making it unusable without some onerous license.

I do not recall, although it was quite awhile ago, seeing anything about licensing of code posted when I joined. If it is there then it is all good as long as this board stays up as a refencence for prior art.

Yes, I am paranoid. I have enough experience with lawyers to expect the worst.

 Originally Posted By: NTDOC

:OLoop
The use of GOTO and LABELS is considered [old school, out of date] coding practice. Though quite valid to use, we would rather it be coded to prevent it's use especially for a posted UDF.


Done

 Originally Posted By: NTDOC

Though not required you may want to either code for it or make a point that the SERVER names should not contain a UNC path


This should never happen. The key is the format // + ServerName + / + ShareName. If it does happen the CSCCMD.EXE will throw an error that I capture.

 Originally Posted By: NTDOC

If wanted the use of HKEY_CURRENT_USER can be shortened to: HKCU


Done

 Originally Posted By: NTDOC

As mentioned about making the UDF silent, I would remove some of the minor items still left in that were not silent such as
CLS
? "Pointing Offline Files to New Server..."
etc...


Done

 Originally Posted By: NTDOC

I'm not actually sure what's it's official name is but you may want to preload your arrays in case of an invalid read it would abend KiX

 Code:
$DrvSrvShr = Split(UCase($KeyName),"/",-1)
$DrvSrv = $DrvSrvShr[2]
$DrvShr = $DrvSrvShr[3]



Done

 Originally Posted By: NTDOC

You should also have a CASE1 in case none of your expected results are there in your Select statement.


Done

 Originally Posted By: NTDOC

Good luck and I'll let Glenn carry on from here.


New code is re-posted to the first message (v2.0)

Thanks